Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: Split Model testing into several subunits #3891

Merged
merged 4 commits into from
Jan 5, 2021
Merged

DX: Split Model testing into several subunits #3891

merged 4 commits into from
Jan 5, 2021

Conversation

paulbalandan
Copy link
Member

Description
Closes #3792 .

Checklist:

  • Securely signed commits
  • Unit testing, with >80% coverage
  • Conforms to style guide

@paulbalandan paulbalandan added the testing Pull requests that changes tests only label Nov 16, 2020
@paulbalandan paulbalandan requested a review from MGatner November 23, 2020 12:06
MGatner
MGatner requested changes Nov 23, 2020
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks great! I assume all the test stayed the same, and were just moved to new files, correct? Also a couple comments inline that may or may not need changing.

composer.json Show resolved Hide resolved
system/Database/MigrationRunner.php Show resolved Hide resolved
@paulbalandan
Copy link
Member Author

Generally looks great! I assume all the test stayed the same, and were just moved to new files, correct?

Yes, and I just made a central method to generate a model class and tidied up things.

@MGatner
Copy link
Member

MGatner commented Jan 5, 2021

@paulbalandan Can we get this rebased?

@paulbalandan paulbalandan requested a review from MGatner January 5, 2021 16:04
MGatner
MGatner approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPStan failure allowed. Looks good, thanks for taking this one on! Pet peeve for a long time

@MGatner MGatner merged commit ac1aa13 into codeigniter4:develop Jan 5, 2021
@paulbalandan paulbalandan deleted the split-model-testing branch January 5, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev: Split ModelTest
2 participants
@paulbalandan @MGatner