Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add insert batch timestamps tests #3879

Merged
merged 1 commit into from
Nov 14, 2020
Merged

Add insert batch timestamps tests #3879

merged 1 commit into from
Nov 14, 2020

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Nov 12, 2020

Description
There have a been a few reports of Model::insertBatch() not setting timestamps. This adds some tests to confirm it is at least generally working.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • n/a User guide updated
  • Conforms to style guide

@MGatner MGatner mentioned this pull request Nov 12, 2020
Closed
paulbalandan
paulbalandan approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this first and add more tests to confirm insertBatch's behavior.

@paulbalandan paulbalandan merged commit 752caff into codeigniter4:develop Nov 14, 2020
@MGatner MGatner deleted the insert-batch branch November 14, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGatner @paulbalandan