Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid PHP bug: use Config\Services #374

Merged

Conversation

takekoshinet
Copy link
Contributor

@takekoshinet takekoshinet commented Jan 19, 2017

#373

It's temporary expedient. This avoids fatal error, but there is no change in use arises error...

@coveralls
Copy link

coveralls commented Jan 19, 2017

Coverage Status

Coverage remained the same at 62.233% when pulling 308d993 on noldor:fix/use-services-error into c8d5436 on bcit-ci:develop.

@takekoshinet
Copy link
Contributor Author

$ php -v
PHP 7.0.12 (cli) (built: Jan 18 2017 23:56:04) ( NTS )
Copyright (c) 1997-2016 The PHP Group
Zend Engine v3.0.0, Copyright (c) 1998-2016 Zend Technologies
    with Zend OPcache v7.0.12, Copyright (c) 1999-2016, by Zend Technologies
    with Xdebug v2.5.0, Copyright (c) 2002-2016, by Derick Rethans

$ phpunit 

==== Redirecting to composer installed version in vendor/phpunit ====

PHPUnit 5.3.5 by Sebastian Bergmann and contributors.

.............................................................   61 / 1222 (  4%)
.............................................................  122 / 1222 (  9%)
.............................................................  183 / 1222 ( 14%)
.............................................................  244 / 1222 ( 19%)
.............................................................  305 / 1222 ( 24%)
.............................................................  366 / 1222 ( 29%)
.............................................................  427 / 1222 ( 34%)
.............................................................  488 / 1222 ( 39%)
.............................................................  549 / 1222 ( 44%)
.............................................................  610 / 1222 ( 49%)
.............................................................  671 / 1222 ( 54%)
.............................................................  732 / 1222 ( 59%)
.............................................................  793 / 1222 ( 64%)
.............................................................  854 / 1222 ( 69%)
.............................................................  915 / 1222 ( 74%)
.............................................................  976 / 1222 ( 79%)
............................................................. 1037 / 1222 ( 84%)
............................................................. 1098 / 1222 ( 89%)
............................................................. 1159 / 1222 ( 94%)
............................................................. 1220 / 1222 ( 99%)
..                                                            1222 / 1222 (100%)

Time: 1.26 minutes, Memory: 42.00MB

OK (1222 tests, 1938 assertions)

Generating code coverage report in Clover XML format ... done

@lonnieezell lonnieezell merged commit ea0435e into codeigniter4:develop Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants