Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sqlsrv driver #3714

Merged
merged 59 commits into from
Oct 19, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
1e43715
Update Sqlsrv driver
ferenc-kurucz Jun 23, 2020
be6e8c2
implement _limit() using row ... fetch
ferenc-kurucz Jun 23, 2020
ef5098e
fix delete with limit
ferenc-kurucz Jun 24, 2020
68356ea
add case for Sqlsrv for PreparedQueryTest
ferenc-kurucz Jun 24, 2020
3db85da
fix PreparedQuery
ferenc-kurucz Jun 25, 2020
cf9bd43
add Sqlsrv to DbUtilsTest and ForgeTest
ferenc-kurucz Jun 25, 2020
c6fe113
add Sqlsrv to DBUtilsTest
ferenc-kurucz Jun 25, 2020
92a2188
add Sqlsrv to ForgeTest
ferenc-kurucz Jun 25, 2020
cb35ebc
add Sqlsrv to ForgeTest
ferenc-kurucz Jun 25, 2020
0b4823d
Add null coalescing operator to insertID() and begin adding support …
ferenc-kurucz Jul 1, 2020
2c0585d
Update formatting and continue adding schema support
ferenc-kurucz Jul 1, 2020
687e4ea
Update testListTables to use DBPrefix
ferenc-kurucz Jul 1, 2020
06aac50
Allow dropping columns that are part of an index by droping the index…
ferenc-kurucz Jul 1, 2020
494d120
Update formatting
ferenc-kurucz Jul 1, 2020
c942423
Update formatting
ferenc-kurucz Jul 1, 2020
033fbd9
Update formatting
qury Jul 1, 2020
4e5ebfe
Update formatting
qury Jul 1, 2020
1ebc7c0
fix dataSeek
qury Jul 3, 2020
488650e
Fix Unique key identification
qury Jul 9, 2020
690a738
Implement replace()
qury Jul 9, 2020
8306569
Add db and schema to droptable
qury Jul 13, 2020
7114d79
Move drop table under assert.
qury Jul 13, 2020
e9fc2e3
Fix _droptable typo
qury Jul 13, 2020
5f7d65f
Fix testCompositeKey in ForgeTest
qury Jul 20, 2020
b2cfa81
Add groupby fields to select
qury Jul 20, 2020
f55d105
Repalce array spread with array_merge
qury Jul 20, 2020
8fd337f
fix ForgeTest again
qury Jul 20, 2020
484bf9e
for ForgeTest again
qury Jul 20, 2020
2121569
Update Database Type test table for Sqlsrv
qury Aug 28, 2020
7baa01e
Fix issue with testPaginateForQueryWithGroupBy
qury Sep 6, 2020
1aa527c
Remove id from insert into an autoid field.
qury Sep 6, 2020
4cf0a62
Remove id from insert statement
qury Sep 6, 2020
77e2839
Fix testSaveUpdateRecordObject
qury Sep 6, 2020
7cc0cc7
Fix testUpdateNoPrimaryKey test
qury Sep 6, 2020
6d28d70
fix compileSelect
qury Sep 6, 2020
5e774f2
Add Sqlsrv driver with tests
michalsn Oct 2, 2020
9569208
Make rector happy
michalsn Oct 2, 2020
69f8935
Apply suggestions from code review
michalsn Oct 3, 2020
72c60bd
User guide update [ci skip]
michalsn Oct 3, 2020
e2cd366
Rector fixes
michalsn Oct 3, 2020
8cafecf
Try to speed up the tests
michalsn Oct 3, 2020
50785a2
Code style fixes
michalsn Oct 4, 2020
11ff027
Stop printing errors
michalsn Oct 4, 2020
a689c7e
Changes for comparison query
michalsn Oct 6, 2020
a537b0e
compileSelect update
michalsn Oct 7, 2020
bea4e77
Apply suggestions from code review
michalsn Oct 8, 2020
2355ae3
Cleanup inline comments [ci skip]
michalsn Oct 9, 2020
f7e2ecf
Try to speed up the tests
michalsn Oct 3, 2020
d9d0fce
Code style fixes
michalsn Oct 4, 2020
6d118a2
Stop printing errors
michalsn Oct 4, 2020
01a7217
Try to speed up the tests
michalsn Oct 3, 2020
726cb82
Code style fixes
michalsn Oct 4, 2020
6cd1a98
Stop printing errors
michalsn Oct 4, 2020
2de83f0
Try to speed up the tests
michalsn Oct 3, 2020
921977b
Code style fixes
michalsn Oct 4, 2020
201cbc2
Stop printing errors
michalsn Oct 4, 2020
8bff283
Rector cleanup
michalsn Oct 15, 2020
d0bbab4
Fix orderBy() test
michalsn Oct 15, 2020
f47d3b3
Entity support for result object
michalsn Oct 18, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions .github/workflows/test-phpunit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
fail-fast: false
matrix:
php-versions: ['7.2', '7.3', '7.4']
db-platforms: ['MySQLi', 'Postgre', 'SQLite3']
db-platforms: ['MySQLi', 'Postgre', 'SQLite3', 'Sqlsrv']
michalsn marked this conversation as resolved.
Show resolved Hide resolved

services:
mysql:
Expand All @@ -61,22 +61,34 @@ jobs:
ports:
- 5432:5432
options: --health-cmd=pg_isready --health-interval=10s --health-timeout=5s --health-retries=3
mssql:
image: microsoft/mssql-server-linux:2017-latest
env:
SA_PASSWORD: 1Secure*Password1
ACCEPT_EULA: Y
MSSQL_PID: Developer
ports:
- 1433:1433
redis:
image: redis
ports:
- 6379:6379
options: --health-cmd "redis-cli ping" --health-interval=10s --health-timeout=5s --health-retries=3

steps:
- name: Create database for MSSQL Server
if: ${{ matrix.db-platforms == 'Sqlsrv'}}
michalsn marked this conversation as resolved.
Show resolved Hide resolved
run: sqlcmd -S localhost -U sa -P 1Secure*Password1 -Q "CREATE DATABASE test"

- name: Checkout
uses: actions/checkout@v2

- name: Setup PHP, with composer and extensions
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-versions }}
tools: composer:v2
extensions: imagick
tools: composer:v2, pecl
extensions: imagick, sqlsrv
coverage: xdebug
env:
update: true
Expand Down
8 changes: 4 additions & 4 deletions phpstan.neon.dist
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ parameters:
- system/Validation/Views/single.php
ignoreErrors:
- '#Access to an undefined property CodeIgniter\\Database\\Forge::\$dropConstraintStr#'
- '#Access to an undefined property CodeIgniter\\Database\\BaseConnection::\$mysqli#'
- '#Access to an undefined property CodeIgniter\\Database\\ConnectionInterface::(\$DBDriver|\$connID|\$likeEscapeStr|\$likeEscapeChar|\$escapeChar|\$protectIdentifiers)#'
- '#Access to an undefined property CodeIgniter\\Database\\BaseConnection::\$mysqli|\$schema#'
- '#Access to an undefined property CodeIgniter\\Database\\ConnectionInterface::(\$DBDriver|\$connID|\$likeEscapeStr|\$likeEscapeChar|\$escapeChar|\$protectIdentifiers|\$schema)#'
- '#Access to an undefined property CodeIgniter\\HTTP\\Request::\$uri#'
- '#Access to protected property CodeIgniter\\Database\\BaseConnection::(\$DBDebug|\$DBPrefix|\$swapPre|\$charset|\$DBCollat)#'
- '#Access to protected property CodeIgniter\\Database\\BaseConnection::(\$DBDebug|\$DBPrefix|\$swapPre|\$charset|\$DBCollat|\$database)#'
- '#Call to an undefined method CodeIgniter\\Database\\BaseConnection::_(disable|enable)ForeignKeyChecks\(\)#'
- '#Call to an undefined method CodeIgniter\\Database\\BaseConnection::supportsForeignKeys\(\)#'
- '#Call to an undefined method CodeIgniter\\Database\\ConnectionInterface::(tableExists|protectIdentifiers|setAliasedTables|escapeIdentifiers|affectedRows|addTableAlias)\(\)#'
- '#Call to an undefined method CodeIgniter\\Database\\ConnectionInterface::(tableExists|protectIdentifiers|setAliasedTables|escapeIdentifiers|affectedRows|addTableAlias|getIndexData)\(\)#'
- '#Call to an undefined method CodeIgniter\\HTTP\\Request::(getPath|getSegments|getMethod|setLocale|getPost)\(\)#'
- '#Call to an undefined method CodeIgniter\\Router\\RouteCollectionInterface::(getDefaultNamespace|isFiltered|getFilterForRoute|getRoutesOptions)\(\)#'
- '#Call to function is_null\(\) with mysqli_stmt\|resource will always evaluate to false#'
Expand Down
Loading