Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix countAllResults() when DBPrefix is defined #3653

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Fix countAllResults() when DBPrefix is defined #3653

merged 1 commit into from
Sep 17, 2020

Conversation

michalsn
Copy link
Member

Description
This PR fixes the countAllResults() method when DBPrefix is defined and additionally we use groupBy() or distinct() method with the query.

Fixes #3651

A DBPrefix was always added again to the next query when the countAllResults() method was set to not reset the SELECT part.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner MGatner merged commit 729f767 into codeigniter4:develop Sep 17, 2020
@michalsn michalsn deleted the fix/countAllResults_with_DBPrefix branch September 19, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: SQL Error when countAllResults, groupBy and DBPrefix used together
2 participants
@michalsn @MGatner