Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Router): reset filter info before get defined filters #3592

Merged
merged 2 commits into from
Sep 3, 2020
Merged

fix(Router): reset filter info before get defined filters #3592

merged 2 commits into from
Sep 3, 2020

Conversation

lefuentes
Copy link
Contributor

@lefuentes lefuentes commented Sep 2, 2020 •
edited
Loading

Description
Fix #3591

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@nyufeng
Copy link
Contributor

nyufeng commented Sep 3, 2020

Look great ! But, should have PHPUnit to test this.

Travis CI error, Seems to be malfunctioning.

MGatner
MGatner approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An elegant solution! The failed test is unrelated. I will let @michalsn take a look but I think this is universally desirable.

michalsn
michalsn approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Also, thank you for your first contribution to this project!

@michalsn michalsn merged commit ea75fc6 into codeigniter4:develop Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Route Filters doesn't restart in FeatureTestCase.
4 participants
@lefuentes @nyufeng @michalsn @MGatner