Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional pretty SQL syntax in toolbar #3515

Closed
wants to merge 1 commit into from
Closed

Optional pretty SQL syntax in toolbar #3515

wants to merge 1 commit into from

Conversation

enix-app
Copy link
Contributor

@enix-app enix-app commented Aug 19, 2020

Description
I think this is hidden feature. Works (only) if highlightjs.php installed in vendor dir.

Light mode:

before_light

after_light

Dark mode:

before_dark

after_dark

Tested with myth/auth and tatter/relations.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn
Copy link
Member

There are some code style tweaks that should be fixed.

Other than that... I'm not sure if support for this specific external library should be included in the core (but this is only my opinion). I would say: "no", but maybe others have a different opinion. So... let's wait and see.

@MGatner
Copy link
Member

MGatner commented Aug 20, 2020

I agree that we cannot include a specific third-party class. Some ideas:

  1. It looks like this functionality would not be hard to reproduce. We could host our own version, pared down to just what we need.

  2. Alternatively this would make a great module, e.g. codeigniter4-toolbar-highlights. It could include the third party package and reformatted toolbar collectors just as you have here.

I must say I like the result. My toolbar text is often unreadable because of dark text on dark backgrounds, and I have to hover or highlight content to read it. This could be part of a larger pass to make sure toolbar text is consistently "pretty".

@enix-app
Copy link
Contributor Author

enix-app commented Sep 9, 2020

I can't comment more because I have problem with my English.

So simply. If you have working with composer, the toolbar works fine if you have installed hljsphp. This works only in development mode. I think this is not affected in your production. So, if the package not maintained we can change the future :).

Sadly, I can't explore more the toolbar because view parser has limitations.

I think, I really like CodeIgniter's debug toolbar.

@enix-app enix-app closed this Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants