Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize RouteCollection : use foreach instead of for with count when possible #3281

Merged
merged 2 commits into from
Jul 12, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions system/Router/RouteCollection.php
Original file line number Diff line number Diff line change
Expand Up @@ -831,10 +831,9 @@ public function resource(string $name, array $options = null): RouteCollectionIn
if (isset($options['except']))
{
$options['except'] = is_array($options['except']) ? $options['except'] : explode(',', $options['except']);
$c = count($methods);
for ($i = 0; $i < $c; $i ++)
foreach ($methods as $i => $method)
{
if (in_array($methods[$i], $options['except']))
if (in_array($method, $options['except']))
{
unset($methods[$i]);
}
Expand Down Expand Up @@ -946,10 +945,9 @@ public function presenter(string $name, array $options = null): RouteCollectionI
if (isset($options['except']))
{
$options['except'] = is_array($options['except']) ? $options['except'] : explode(',', $options['except']);
$c = count($methods);
for ($i = 0; $i < $c; $i ++)
foreach ($methods as $i => $method)
{
if (in_array($methods[$i], $options['except']))
if (in_array($method, $options['except']))
{
unset($methods[$i]);
}
Expand Down