Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update html_helper.php #3247

Merged
merged 2 commits into from
Jul 11, 2020
Merged

Update html_helper.php #3247

merged 2 commits into from
Jul 11, 2020

Conversation

avegacms
Copy link
Contributor

@avegacms avegacms commented Jul 8, 2020 •
edited by kenjis
Loading

Added hreflang parameter for link_tag function for calling <link href="https://domain.com/en" hreflang="x-default" rel="alternate"> and etc. And added checks for tags with rel expressions for 'alternate','canonical' in this case attribute type dont use

Each pull request should address a single issue and have a meaningful title.

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@avegacms
Update html_helper.php
aaebccd 
Added hreflang parameter for link_tag function for calling <link href="https://domain.com/en" hreflang="x-default" rel="alternate"> and etc. And added checks for tags with rel expressions for  'alternate','canonical'  in this case attribute type dont use
@avegacms
Copy link
Contributor Author

avegacms commented Jul 8, 2020

Added hreflang parameter for link_tag function for calling and etc. And added checks for tags with rel expressions for 'alternate','canonical' in this case attribute type dont use

MGatner
MGatner requested changes Jul 8, 2020
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change but pleas pay attention to the style guide. See comments.

system/Helpers/html_helper.php Outdated Show resolved Hide resolved
system/Helpers/html_helper.php Outdated Show resolved Hide resolved
@avegacms
Update html_helper.php
a7bafc2 
Updated code by style guide
@avegacms avegacms requested a review from MGatner July 11, 2020 06:00
MGatner
MGatner approved these changes Jul 11, 2020
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you!

@MGatner MGatner merged commit 5d0b3cd into codeigniter4:develop Jul 11, 2020
@kenjis kenjis added tests needed Pull requests that need tests docs needed Pull requests needing documentation write-ups and/or revisions. labels Dec 25, 2022
@kenjis kenjis mentioned this pull request Dec 25, 2022
Merged
5 tasks
@kenjis kenjis added the enhancement PRs that improve existing functionalities label Dec 25, 2022
@kenjis
Copy link
Member

kenjis commented Dec 25, 2022

@avegacms I sent a PR #7022 to fix link_tag().
If it breaks your app, please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
docs needed Pull requests needing documentation write-ups and/or revisions. enhancement PRs that improve existing functionalities tests needed Pull requests that need tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avegacms @kenjis @MGatner