Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature seed command #3234

Merged
merged 12 commits into from
Jul 10, 2020
Merged

Feature seed command #3234

merged 12 commits into from
Jul 10, 2020

Conversation

abilioposada
Copy link
Contributor

@abilioposada abilioposada commented Jul 6, 2020 •
edited
Loading

Description
Add seed command generation

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@abilioposada
Add seed language
13c016e 
Add seed language file
@abilioposada
Add create seeder
9100330 
Add create seeder file
@lonnieezell
Copy link
Member

Thanks for this. Please change the command name to make:seeder, though. I'd like to start getting more CLI generators in place eventually, so let's make a place for them to live.

@abilioposada
Copy link
Contributor Author

@paulbalandan I was following system/Commands/Database/CreateMigration.php file, but I can do all those changes

@abilioposada
Change command name
812e8ed 
Change the command name
@abilioposada abilioposada changed the title Abilioposada/feature seed command Feature seed command Jul 6, 2020
@lonnieezell
Copy link
Member

@abilioposada Yes, please follow @paulbalandan suggestions. Things have been formalized more since the CreateMigration command was originally written. It will be revisited at some point in the future. :)

And thanks for this!

@michalsn michalsn merged commit bb122e0 into codeigniter4:develop Jul 10, 2020
@michalsn
Copy link
Member

Nice work! Thanks, @abilioposada, and @paulbalandan.

@abilioposada abilioposada deleted the abilioposada/feature-seed-command branch July 10, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell left review comments

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abilioposada @lonnieezell @michalsn @paulbalandan