Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Throwable in catch block of filesystem helper #3227

Merged
merged 1 commit into from
Jul 5, 2020
Merged

Use Throwable in catch block of filesystem helper #3227

merged 1 commit into from
Jul 5, 2020

Conversation

paulbalandan
Copy link
Member

Description
Replace Exception with Throwable in catch blocks of other filesystem helpers. Others are using Throwable while these are not. Seems odd to me.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn merged commit 8b09ab8 into codeigniter4:develop Jul 5, 2020
@paulbalandan paulbalandan deleted the use-throwable branch July 5, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbalandan @michalsn