Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check color support for STDERR for CLI::error #3226

Merged
merged 1 commit into from
Jul 5, 2020
Merged

Check color support for STDERR for CLI::error #3226

merged 1 commit into from
Jul 5, 2020

Conversation

paulbalandan
Copy link
Member

Description
Since CLI::error uses STDERR as stream, this PR attempts to check if the stream supports terminal colors by modifying the $isColored variable used by CLI::color. Afterwards, this returns the variable to its previous state.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn merged commit 789a77c into codeigniter4:develop Jul 5, 2020
@paulbalandan paulbalandan deleted the update-cli-error branch July 5, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbalandan @michalsn