Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'exit code 23' in apidocs action #3225

Merged
merged 2 commits into from
Jul 5, 2020
Merged

Fix 'exit code 23' in apidocs action #3225

merged 2 commits into from
Jul 5, 2020

Conversation

paulbalandan
Copy link
Member

Description
In #3183 (comment), the action exits on Download phpDocumentor step with code 23. I must admit that there was an oversight when I copied the working version of the action in my test branch to that PR branch. I have overlooked adding cd ./source before calling curl.

Green build is on this PR's first commit.
Test fix for apidocs locally

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn merged commit bbf5741 into codeigniter4:develop Jul 5, 2020
@michalsn
Copy link
Member

michalsn commented Jul 5, 2020

Thanks!

@paulbalandan paulbalandan deleted the apidocs-fix branch July 5, 2020 06:20
@MGatner
Copy link
Member

MGatner commented Jul 5, 2020

Action is green! Yay! Thanks so much @paulbalandan, very nice work.

@lonnieezell
Copy link
Member

Yes, thanks so much! And the docs are up to date, now, too. Yay!

@MGatner
Copy link
Member

MGatner commented Jul 6, 2020

Finally, no more reading docs on GitHub!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants