Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix result object handling in Model class #3224

Merged
merged 4 commits into from
Jul 5, 2020
Merged

Fix result object handling in Model class #3224

merged 4 commits into from
Jul 5, 2020

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Jul 4, 2020 •
edited
Loading

Description
This PR fixes incorrect handling of result objects in the Model class.

Ref: #3204 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Conforms to style guide

MGatner
MGatner approved these changes Jul 5, 2020
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven’t dug into this issue or solution but the code and tests look quality and make sense. If you feel confident in it feel free to merge!

@michalsn michalsn merged commit e1ac9d7 into codeigniter4:develop Jul 5, 2020
@michalsn michalsn deleted the fix_model_result branch July 16, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalsn @MGatner