Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove underscore in UG build path #3218

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Remove underscore in UG build path #3218

merged 1 commit into from
Jul 4, 2020

Conversation

paulbalandan
Copy link
Member

Description
In comment to #3167 , docs still fails the build process. Done a little checking and found that we used the build path as _build instead of build used in the Makefile.

Checked this locally for a green build: https://github.com/paulbalandan/CodeIgniter4/actions/runs/157521660

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner
Copy link
Member

MGatner commented Jul 4, 2020

Ooo that would be great if this got the Action going! This one has been a pain. Good catch!

@MGatner MGatner merged commit e11ff0d into codeigniter4:develop Jul 4, 2020
@paulbalandan paulbalandan deleted the docs-nightly branch July 4, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants