Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra slash in URI #3202

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Jul 2, 2020

Description
Using FeatureTestCase::get('/') currently results in a URI of // due to an extra slash in the URI. This resolves fine during auto-routing but circumvents explicit route definitions such as $routes->get('/', 'Foo::index');.

This PR ensures the slashes are correct going into the URI regardless of baseUrl and $path.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • n/a User guide updated
  • Conforms to style guide

@michalsn michalsn merged commit 8bd6644 into codeigniter4:develop Jul 3, 2020
@MGatner MGatner deleted the feature-slash branch July 3, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants