Added SameSite attribute to CSRF cookie #3037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to PHP 7.0.3 `setcookie()` lacks an `$options` parameter. SameSite is therefore added to the path parameter.
lonnieezell
requested changes
May 31, 2020
app/Config/App.php
Outdated
| @@ -239,13 +239,15 @@ class App extends BaseConfig | |||
| | CSRFTokenName = The token name | |||
| | CSRFHeaderName = The header name | |||
| | CSRFCookieName = The cookie name | |||
| | CSRFCookieSameSite = The cookie SameSite attribute (none, Lax or Strict) | |||
There was a problem hiding this comment.
Case for these should match what a developer is expected to use. You're using all lowercase below, but these are listed out as Initial Caps.
SameSite CamelCase description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to provide an additional layer of defense against cross-site request forgery (CSRF) attacks, the SameSite attribute is added to the CSRF cookie.
Checklist: