fix. toolbar disable,view comment not remove

[nyufeng]

• fix Bug: Filters 'except' option not removing DebugToolbar comment for view #3002. toolbar disable,but view comment not remove.
• delete filter argumets support. because, filter muset implements FilterInterface. before only receive request. so, if filter argumetns send to before, will get an error.
• Alias resolution is no longer done in the run method, Filters::$filtersClass save alias to class
  Checklist:
• FiltersTest. append aliases to config
• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[MGatner]

Thank you @Instrye - this looks like quite a bit of work and some good changes. I don't have my head around it, I'll have to try another day. In the meantime, anybody else willing to give it a review?

[paulbalandan]

This needs to be revised to incorporate changes in FilterInterface.

[samsonasik]

@MGatner could you re-check it? thanks

[MGatner]

A few issues failing the static analysis check, but otherwise this looks good. Waiting on Travis. @samsonasik should we merge despite the CS failures? Or resolve those first?

[samsonasik]

@MGatner I think code static analysis check need to incorporated first:

 ------ ----------------------------------------------------------------------- 
  Line   system/Filters/Filters.php                                             
 ------ ----------------------------------------------------------------------- 
  157    Access to an undefined property                                        
         CodeIgniter\Filters\Filters::$argumentsClass.                          
  183    Access to an undefined property                                        
         CodeIgniter\Filters\Filters::$argumentsClass.                          
  338    Access to an undefined property                                        
         CodeIgniter\Filters\Filters::$argumentsClass.                          
  495    Return typehint of method                                              
         CodeIgniter\Filters\Filters::processAliasesToClass() has invalid type  
         CodeIgniter\Filters\type.                                              
  497    Method CodeIgniter\Filters\Filters::processAliasesToClass() should     
         return CodeIgniter\Filters\type but return statement is missing.      

[MGatner]

Looks good! @michalsn any thoughts before merge?

[MGatner]

@Instrye It looks like one more round of tweaks, if you're available for those.

[nyufeng]

😂I want to provide quality phpdoc, But my English level hinders me.

[michalsn]

Looks good, thanks!

You only have to resolve some conflicts with the develop branch and I think we're good to go.

[nyufeng]

@michalsn Everything's ready.

[michalsn]

Thanks!