Force devs to turn off zlib.output_compression ini in 'pre-system' event #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does travis have a problem lately? Or this is my problem?
I keep getting these errors. |
|
Travis does occasionally have that issue. It's a random occurrence as far as I can tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This answers issue #2980 and is related to #2182.
In the 'pre-system' event, added a check if
zlib.output_compressionini is turned on. If it does, pages will be blank so this check warns devs for this scenario. The exception thrown will be managed by the exception_handler, resulting to these snippets:// browser
// terminal
Checklist: