Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable name #2973

Merged
merged 1 commit into from
May 15, 2020
Merged

Fix variable name #2973

merged 1 commit into from
May 15, 2020

Conversation

ByeongUkChoi
Copy link
Contributor

Property name is wrong

@MGatner
Copy link
Member

MGatner commented May 15, 2020

It's odd that this hasn't caused issues or test failures, but I think you are correct that this would have prevented reusing stored results.

@MGatner MGatner merged commit 9bbc991 into codeigniter4:develop May 15, 2020
ByeongUkChoi
ByeongUkChoi commented May 16, 2020
View reviewed changes
Copy link
Contributor Author

@ByeongUkChoi ByeongUkChoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@ByeongUkChoi ByeongUkChoi deleted the database-result branch May 16, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ByeongUkChoi @MGatner