Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] User Guide: Update welcome image to version 4.0.3 #2914

Merged
merged 2 commits into from
May 6, 2020

Conversation

jlamim
Copy link
Contributor

@jlamim jlamim commented May 1, 2020

Description
Update of the page image and welcome to display the structure of version 4.0.3 instead of version 4.0.0-rc.4, avoiding confusion on the part of beginners.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell
Copy link
Member

Actually - to save us from having to do this every time, would you mind just removing the version number from the graphic altogether, so it just says "Welcome to CodeIgniter"? That would be helpful.

@jlamim
Copy link
Contributor Author

jlamim commented May 1, 2020

@lonnieezell Updated image without specifying the version.

@samsonasik
Copy link
Member

The view at app/Views/welcome_message.php needs to be updated.

@lonnieezell lonnieezell merged commit 5f9f9d9 into codeigniter4:develop May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants