Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved subjects in Controller and Routing chapter #2908

Merged
merged 2 commits into from
May 1, 2020

Conversation

jreklund
Copy link
Contributor

Another day, another chapter. Now I went over "Controllers and Routing" chapter of the user guide.

  • Tabs to space. Added tables. etc
  • Added additional information to Controllers about PSR-4
  • IncomingRequest Class - Class Reference from parent where incorrect
  • HTTP Messages - Methods where incorrect and incomplete
  • Request Class - Methods where incomplete
  • URI Routing - "Method" referenced as "function"
  • getVar referenced as it only got two parameters, there are a third one.

What is left to do:

IncomingRequest Class
    php:method (missing functions, and checking current ones)
Content Negotiation
    php:class
        php:method (all, as it non existing)

Demo at:
https://codeigniter.johaneklund.com/userguide/master/incoming/controllers.html

Checklist:

  • Securely signed commits
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit b83f16c into codeigniter4:develop May 1, 2020
@jreklund jreklund deleted the controllers-and-routing branch May 1, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants