Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make validation placeholders always available #2897

Merged

Conversation

jreklund
Copy link
Contributor

Same as #2882 but without rebase... this are based on develop instead.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
MGatner MGatner
@samsonasik
Copy link
Member

@lonnieezell can this be included to 4.0.3 as well please? Just note I think the validationRules documentation removal need to be reverted (just the userguide part) as that still works, as I commented above.

@jreklund
Copy link
Contributor Author

I will soon patch that in again, didn't have the time yesterday.

@jreklund
Copy link
Contributor Author

The "Validation Placeholders" have been reverted. I also took some time to fix a couple of other things like:

  • Spaces instead of tabs.
  • new \App\Models\UserModel(); instead of new App\Models\UserModel();
  • [] instead of array()
  • setValidationMessage and setValidationMessages didn't render correctly

You can view it here if you fint it easier:
https://codeigniter.johaneklund.com/userguide/master/models/model.html

@lonnieezell lonnieezell merged commit 73d6ae6 into codeigniter4:develop May 1, 2020
@lonnieezell
Copy link
Member

It is in 4.0.3! Thanks.

@jreklund jreklund deleted the validation-placeholders-again branch May 1, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants