Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability to delete row with string primary key via Model::delete($id) #2894

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Added ability to delete row with string primary key via Model::delete($id) #2894

merged 1 commit into from
Apr 28, 2020

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Apr 27, 2020 •
edited
Loading

To make enable to delete row with string primary key via Model::delete($id)

Checklist:

  • Securely signed commits
  • Unit testing, with >80% coverage

@samsonasik samsonasik changed the title Added ability to string primary key via Model::delete($id) Added ability to delete row with string primary key via Model::delete($id) Apr 27, 2020
@samsonasik samsonasik force-pushed the add-ability-to-delete-non-numeric-pkey-from-model branch from 6e59f9c to 243c583 Compare April 27, 2020 16:21
@samsonasik
Copy link
Member Author

travis build green 🎉

@lonnieezell lonnieezell merged commit 00d0a9d into codeigniter4:develop Apr 28, 2020
@samsonasik samsonasik deleted the add-ability-to-delete-non-numeric-pkey-from-model branch April 28, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @lonnieezell