add $segment parameter in pager call by Model.php #2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add the $segment option when the Pager library is call by the model paginate function
samsonasik
requested changes
Apr 18, 2020
jreklund
suggested changes
Apr 19, 2020
|
Please update the docs to reflect this change and then I think we're good. |
|
I don't know what to write in the docs and the other optional param "$page" is not in the docs |
|
No worries, I'll update it. Thanks. FYI - from your comments here - your English is fine. :) |
|
Good thx you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i don't know why the $segment parameter is not present when the Pager library is call by the Model paginate function
add the $segment option when the Pager library is call by the Model paginate function