Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability for nested language definition #2833

Merged

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Apr 16, 2020

So, the language file can have something like:

<?php
// Nested.php
return [
   'a' => [
	   'b' => [
		   'c' => [
			   'd' => 'e',
		   ],
	   ],
   ],
];

and can be called with lang('Nested.a.b.c.d');

Checklist:

  • Securely signed commits
  • Unit testing, with >80% coverage
  • User guide updated

@samsonasik
Copy link
Member Author

travis build green 🎉

@lonnieezell
Copy link
Member

This needs a mention in the docs and then it's good to go.

@samsonasik samsonasik force-pushed the add-ability-for-nested-language branch from 7ac1430 to ac22f27 Compare April 17, 2020 07:53
@samsonasik
Copy link
Member Author

@lonnieezell I've updated documentation for support nested language definition addition.

@lonnieezell
Copy link
Member

Looks good. Thanks.

@lonnieezell lonnieezell merged commit bf135da into codeigniter4:develop Apr 17, 2020
@samsonasik samsonasik deleted the add-ability-for-nested-language branch April 17, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants