Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make named constructor in Exception classes consistent: use return instead of throw #2809

Merged

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Apr 6, 2020

As the callers already call throw and most other exception classes uses return.

Checklist:

  • Securely signed commits

@lonnieezell lonnieezell merged commit 241a54e into codeigniter4:develop Apr 6, 2020
@samsonasik samsonasik deleted the named-constructor-return branch April 6, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants