Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resetting QBFrom part #2802

Merged
merged 2 commits into from
Apr 6, 2020
Merged

Add resetting QBFrom part #2802

merged 2 commits into from
Apr 6, 2020

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Apr 5, 2020

Description
The QBFrom part is not resetting. That can lead to unexpected results when combined with a call to from method. This pull request makes sure that only first table from QBFrom array is saved after the query is executed.

Ref: #2800

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit 1092399 into codeigniter4:develop Apr 6, 2020
@michalsn michalsn deleted the feature/qb_from_reset branch July 16, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalsn @lonnieezell