Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncommented tests, mistake in my previous PR :( #2767

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Uncommented tests, mistake in my previous PR :( #2767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions tests/system/Validation/ValidationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ public function testRulesForArrayField($body, $rules, $results)
public function arrayFieldDataProvider()
{
return [
'all_rules_should_pass' => [
'all_rules_should_pass' => [
'body' => [
'foo' => [
'a',
Expand All @@ -683,41 +683,41 @@ public function arrayFieldDataProvider()
],
'results' => [],
],
/*'first_field_will_return_required_error' => [
'body' => [
'first_field_will_return_required_error' => [
'body' => [
'foo' => [
'',
'b',
'c'
]
'c',
],
],
'rules' => [
'rules' => [
'foo.0' => 'required|alpha|max_length[2]',
'foo.1' => 'required|alpha|max_length[2]',
'foo.2' => 'required|alpha|max_length[2]'
'foo.2' => 'required|alpha|max_length[2]',
],
'results' => [
'foo.0' => 'The foo.0 field is required.'
]
'foo.0' => 'The foo.0 field is required.',
],
],
'first_and second_field_will_return_required_and_min_length_error' => [
'body' => [
'body' => [
'foo' => [
'',
'b',
'c'
]
'c',
],
],
'rules' => [
'rules' => [
'foo.0' => 'required|alpha|max_length[2]',
'foo.1' => 'required|alpha|min_length[2]|max_length[4]',
'foo.2' => 'required|alpha|max_length[2]'
'foo.2' => 'required|alpha|max_length[2]',
],
'results' => [
'foo.0' => 'The foo.0 field is required.',
'foo.1' => 'The foo.1 field must be at least 2 characters in length.',
]
]*/
],
],
];
}

Expand Down