Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation for multi select #2765

Conversation

musmanikram
Copy link
Contributor

Fix #2757

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
musmanikram usman ikram

Verified

This commit was signed with the committer’s verified signature.
musmanikram usman ikram

Verified

This commit was signed with the committer’s verified signature.
musmanikram usman ikram

Verified

This commit was signed with the committer’s verified signature.
musmanikram usman ikram

Verified

This commit was signed with the committer’s verified signature.
musmanikram usman ikram

Verified

This commit was signed with the committer’s verified signature.
musmanikram usman ikram
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but maybe somebody else with more dot array experience could take a peek before merging?

@lonnieezell
Copy link
Member

Seems ok to me. Merging.

@lonnieezell lonnieezell merged commit 93f1a65 into codeigniter4:develop Mar 28, 2020
],
'first_field_will_return_required_error' => [
/*'first_field_will_return_required_error' => [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering, why this data provider commented ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ 🤦‍♂️ 🤦‍♂️ My bad. Will create another PR.

Thank you for pointing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Multiple select validation problem
4 participants