Fixes #2725 : move logging directory path config to CodeIgniter\Log\Handlers\FileHandler config

[samsonasik]

Fixes #2725 . The Logger::$path config never get as it tried to access the path config in "CodeIgniter\Log\Handlers\FileHandler" config under Logger::$handlers property. Also, the ?? parameter make test for nullable/not isset, while it check the empty string value. Now, to avoid BC break, I use the following flow:

note: $config is a configuration under Logger::$handlers['CodeIgniter\Log\Handlers\FileHandler'], not Logger class properties

• set $config['path'] to $config['path'] if isset, fallback to WRITEPATH . 'logs/';
• $this->path to $config['path'] if not empty string, fallback to WRITEPATH . 'logs/';

Checklist:

• Securely signed commits
• Unit testing, with >80% coverage

[samsonasik]

Got error in test : "fopen(vfs://root/log-2020-03-20.log): failed to open stream: "org\bovigo\vfs\vfsStreamWrapper::stream_open" call failed". It seems the vfsStream() put -> read requires tweak.

[samsonasik]

The test has been tweaked for writing file with vfsStream

[samsonasik]

travis build green 🎉

[MGatner]

This looks good to me. There should be no need for path in the base config since it is handled-specific. Since it’s a change to app I’d like @lonnieezell to take a look before merging. Also @dafriend has spent a lot of time with logging recently and may have some input.
Thanks for the work, these have been very solid PRs.

[samsonasik]

I close re-open the PR to re-trigger travis build

[samsonasik]

@dafriend I applied your suggestion, travis build green 🎉

[lonnieezell]

I think this change makes sense. My initial reaction was that it was a BC change that would cause a new MAJOR release, which we don't want to do. But I think another PR just removed that anyway, since it wasn't being used, and this doesn't affect the API so I think we're OK. Will merge.