-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging Refactor #2656
Logging Refactor #2656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not able to complete a review of this code. All of changes to the config file need to be rolled back. We are not anywhere close to being ready for a BC breaking change, and almost all of the changes were unnecessary, but do to a preference.
Once that has been refactored out I can review the logic changes without all of the changes that the config file changes required.
* should be written to the log file. | ||
* | ||
* Here are the values and the message type | ||
* 0 - off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove the examples from this list?
* | ||
* For a live site you'll usually want critical (3) or lower to be logged, otherwise | ||
* your log files will fill up very fast. | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This amount of text is more appropriate for user guide than a doc block. The list of levels was provided as a quick reference only.
* | ||
* @var integer|array | ||
*/ | ||
public $fileLevelsHandled = 8; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the name back as this is definitely a BC break since this requires a change in every application that has been started on the framework so far.
Description
Fix Chrome Logger per #2616
But wait! There's more...
Checklist:
This might be a breaking change in that
\Config\Logger
has changed. Some new properties were added and others were effectively renamed.However, the overall API is not changed and
Logger
still conforms to PSR-3.