Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON error on recursion in data #2655

Merged
merged 4 commits into from
Mar 9, 2020
Merged

Fix JSON error on recursion in data #2655

merged 4 commits into from
Mar 9, 2020

Conversation

MashinaMashina
Copy link
Contributor

@MashinaMashina MashinaMashina commented Mar 1, 2020 •
edited
Loading

Bugs:
#2434 and #2586

! $result && needs because json_encode generating result, all is ok, but json_last_error() anyway eqally error "Type not supported"

@MashinaMashina
Copy link
Contributor Author

I do not know what to do with tests.
In #2586 I want get error from database, not json formatter

@lonnieezell lonnieezell merged commit 5093694 into codeigniter4:develop Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MashinaMashina @michalsn @lonnieezell