Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape php binary - fixes #2367 #2651

Merged
merged 1 commit into from
Feb 29, 2020
Merged

Escape php binary - fixes #2367 #2651

merged 1 commit into from
Feb 29, 2020

Conversation

michalsn
Copy link
Member

Description
To avoid path problems, we should use escapeshellarg function for PHP_BINARY.
See: #2367

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

MGatner
MGatner approved these changes Feb 29, 2020
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. You’re so fast! Thanks for this - just making sure tests all pass.

@MGatner MGatner merged commit 649f4c0 into codeigniter4:develop Feb 29, 2020
@michalsn michalsn deleted the escape_binary branch March 5, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalsn @MGatner