Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filesystem_helper #259

Merged
merged 2 commits into from
Sep 24, 2016
Merged

Filesystem_helper #259

merged 2 commits into from
Sep 24, 2016

Conversation

Portaflex
Copy link
Contributor

Initial pull request. Filesystem_helper merging directory_helper, file_helper and path_helper.

Don't have tests because can't get vfsStream to work.

@Portaflex Portaflex mentioned this pull request Sep 11, 2016
@lonnieezell
Copy link
Member

What issues are you having getting vfsStream to work? I've never actually used it but can maybe point you in the right general direction. I appreciate all of the help, but we really need tests on all of these things...

@Portaflex
Copy link
Contributor Author

Portaflex commented Sep 12, 2016

I can install vfsStream using composer, but can't instantiate none of its files. Don't know how to manage namespaces and psr-4 in this case:

_test_dir = vfsStreamWrapper::getRoot(); } ```

@lonnieezell
Copy link
Member

Looking at the example in the wiki, you're missing the namespace for vfsstream. Outside of the class (right below the namespace declaration) you'd need to put:

use org\bovigo\vfs\vfsStream,
    org\bovigo\vfs\vfsStreamDirectory;

@lonnieezell
Copy link
Member

@Portaflex are you going to be able to do any more on this?

@Portaflex
Copy link
Contributor Author

I can't instantiate vfsStream. Sorry. So, that's a "no".

@lonnieezell
Copy link
Member

Even with the use statement in place? Hmmm. Alright, I'll try to take a look at it soon.

@lonnieezell lonnieezell merged commit 962c131 into codeigniter4:develop Sep 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants