Cache FileHandler unlink exception #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the cache
FileHandlerchecks for the existence of the file, reads its contents, then if the TTL has expired it removes the file. Because of the disk operation to read the file and unserialize its contents it is conceivable (and has happened to me a few times) that concurrent calls actually interlace the removal of the file between its check and the second removal attempt, leading to an exception when it tries tounlinkthe non-existent file. This PR adds a second check to confirm the file still exists, which should ensure no two calls attempt to remove the same file.Checklist: