Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable buffer check on "testing" environment #2551

Merged

Conversation

samsonasik
Copy link
Member

Description
To clean up the buffer notice in "testing" environment which previously shows:

There were 3 risky tests:

1) CodeIgniter\CodeIgniterTest::testRunClosureRoute
Test code or tested code did not (only) close its own output buffers

2) CodeIgniter\CodeIgniterTest::testRun404OverrideByClosure
Test code or tested code did not (only) close its own output buffers

3) FeatureTestCaseTest::testEchoes
Test code or tested code did not (only) close its own output buffers

Checklist:

  • Securely signed commits

@samsonasik
Copy link
Member Author

From 3 down to 1:

There was 1 risky test:

1) FeatureTestCaseTest::testEchoes
Test code or tested code did not (only) close its own output buffers

@samsonasik samsonasik force-pushed the disable-buffer-check-on-test branch from 575526f to 1a570e4 Compare February 14, 2020 08:48
@MGatner
Copy link
Member

MGatner commented Feb 14, 2020

Wow thanks for this, such an annoyance. I looked into it at one point but was baffled where the issue was. Unfortunate that it is in app/ but this should affect TravisCI more than most users.

@lonnieezell lonnieezell merged commit 3e97caf into codeigniter4:develop Feb 17, 2020
@samsonasik samsonasik deleted the disable-buffer-check-on-test branch February 17, 2020 04:37
@MGatner
Copy link
Member

MGatner commented Feb 22, 2020

We’re still getting one of these. @samsonasik any chance you could look at this last one since you seem to have dug into this issue?

1) FeatureTestCaseTest::testEchoes
366 Test code or tested code did not (only) close its own output buffers

@samsonasik
Copy link
Member Author

I will check the last one when I have a chance ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants