Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Renderer section reset #2509

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Jan 23, 2020

This reverts commit 8c7d874.

Description
Resetting the sections is causing views nested in layout sections not to return their output. My mistake for merging this without testing, also probably shows that we need some more tests in this area. Reverting for now and I will reopen the related issue.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner MGatner merged commit acae11b into codeigniter4:develop Jan 23, 2020
@MGatner MGatner deleted the revert-view-layout branch January 23, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant