Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Renderer - Reset sections after generating the ouput #2502

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

najdanovicivan
Copy link
Contributor

@najdanovicivan najdanovicivan commented Jan 20, 2020

Description
Sections array is left populated after generating output. This creates issues when the same shared View rendered instance is called for the second time.

Fixes #2491

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Sections array is left populated after gnerating output. This creates issues when the same shared View rendered instace is called for the second time.
@MGatner MGatner merged commit 666185f into codeigniter4:develop Jan 20, 2020
@najdanovicivan najdanovicivan deleted the fix-view-layout branch January 20, 2020 21:05
@MGatner
Copy link
Member

MGatner commented Jan 23, 2020

This is actually breaking views nested in layouts, causing renderSection() not to return its output. I'm going to revert this while we look for a different solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with layouts renderer and sections => merge sections in one view
2 participants