Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix. Toolbar init view Error #2490

Merged
merged 4 commits into from
Jan 15, 2020
Merged

fix. Toolbar init view Error #2490

merged 4 commits into from
Jan 15, 2020

Conversation

nyufeng
Copy link
Contributor

@nyufeng nyufeng commented Jan 15, 2020

fix #2464. Services::renderer parameter passing error.

@lonnieezell lonnieezell merged commit a0e802d into codeigniter4:develop Jan 15, 2020
@nyufeng nyufeng deleted the patch-2 branch January 15, 2020 04:55
'CodeIgniter\Debug\Toolbar\Collectors\Routes',
the **app/Config/Toolbar.php** configuration file::

public $collectors = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not have the ::class part.

or '\CodeIgniter\Debug\Toolbar\Collectors\Timers::class' should be changed to \CodeIgniter\Debug\Toolbar\Collectors\Timers::class

Copy link
Contributor Author

@nyufeng nyufeng Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. you are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue passing data to views
3 participants