Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug bar: Dark/light mode + Complete CSS refactoring #2478

Merged
merged 19 commits into from
Feb 23, 2020
Merged

Debug bar: Dark/light mode + Complete CSS refactoring #2478

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
27cb970
Add a "Sun" icon to switch to dark mode
LittleJ Jan 8, 2020
a08fd97
Add a JS function to toggle the dark mode
LittleJ Jan 8, 2020
d05db8d
Add the CSS styles for the dark theme
LittleJ Jan 8, 2020
ade0488
Remove "unsightly" underlining on links with icons
LittleJ Jan 8, 2020
66a61cf
Add "prefers-color-scheme" support
LittleJ Jan 8, 2020
c9f77d6
Add a way using CSS to force light mode
LittleJ Jan 8, 2020
0cea26e
Improved JS to manage special cases with dark/light mode
LittleJ Jan 8, 2020
dc9ee7c
Replace "Sun" by "Low contrast" unicode symbol
LittleJ Jan 19, 2020
f8c2378
Reference the "toolbarContainer"
LittleJ Jan 19, 2020
6dd2520
Apply the theme to the "toolbarContainer" instead of the "toolbar" only
LittleJ Jan 19, 2020
0b6a002
Added the SASS version of the stylesheet
LittleJ Jan 19, 2020
25b651a
Added the compiled and compressed CSS
LittleJ Jan 19, 2020
bd6186f
Changed color for .muted elements
LittleJ Feb 2, 2020
1add909
SASS commenting style changed so it doesn't mess up with the final css
LittleJ Feb 2, 2020
9f70a0c
New uncompressed version of the CSS
LittleJ Feb 2, 2020
3bd15d1
Updated instructions to generate the CSS file
LittleJ Feb 2, 2020
86f7969
Fixed the "Matt Green" color
LittleJ Feb 2, 2020
426fdb2
Moved SASS files from "system/Debug/Toolbar/Views/SASS" to "admin/css…
LittleJ Feb 22, 2020
3b6171b
Moved instructions from the SASS file to "contributinng/css.rst"
LittleJ Feb 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions system/Debug/Toolbar/Views/SASS/_graphic-charter.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// COLORS
// ========================================================================== */

// Themes
$t-dark: #252525;
$t-light: #FFFFFF;

// Glossy colors
$g-blue: #5BC0DE;
$g-gray: #434343;
$g-green: #9ACE25;
$g-orange: #DD8615;
$g-red: #DD4814;

// Matt colors
$m-blue: #D8EAF0;
$m-gray: #DFDFDF;
$m-green: #DFF0D8;
$m-orange: #FDC894;
$m-red: #EF9090;
13 changes: 13 additions & 0 deletions system/Debug/Toolbar/Views/SASS/_mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// MIXINS
// ========================================================================== */

@mixin border-radius($radius) {
border-radius: $radius;
-moz-border-radius: $radius;
-webkit-border-radius: $radius;
}
@mixin box-shadow($left, $top, $radius, $color) {
box-shadow: $left $top $radius $color;
-moz-box-shadow: $left $top $radius $color;
-webkit-box-shadow: $left $top $radius $color;
}
8 changes: 8 additions & 0 deletions system/Debug/Toolbar/Views/SASS/_settings.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
// FONT
// ========================================================================== */

// Standard "sans-serif" font stack used by Github
$base-font: -apple-system, BlinkMacSystemFont, "Segoe UI", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji";

// Default size, all other styles are based on this size
$base-size: 16px;
152 changes: 152 additions & 0 deletions system/Debug/Toolbar/Views/SASS/_theme-dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,152 @@
// IMPORTS
// ========================================================================== */

// The "box-shadow" mixin uses colors
@import '_mixins';

// Graphic charter
@import '_graphic-charter';


// DEBUG ICON
// ========================================================================== */

#debug-icon {
background-color: $t-dark;
@include box-shadow(0, 0, 4px, $m-gray);
a:active, a:link, a:visited {
color: $g-orange;
}
}


// DEBUG BAR
// ========================================================================== */

#debug-bar {
background-color: $t-dark;
color: $m-gray;

// Reset to prevent conflict with other CSS files
h1,
h2,
h3,
p,
a,
button,
table,
thead,
tr,
td,
button,
.toolbar {
background-color: transparent;
color: $m-gray;
}

// Buttons
button {
background-color: $t-dark;
}

// Tables
table {
strong {
color: $m-orange;
}
tbody tr {
&:hover {
background-color: $g-gray;
}
&.current {
background-color: $m-orange;
td {
color: $t-dark;
}
&:hover td {
background-color: $g-red;
color: $t-light;
}
}
}
}

// The toolbar
.toolbar {
background-color: $g-gray;
@include box-shadow(0, 0, 4px, $g-gray);
img {
filter: brightness(0) invert(1);
}
}

// Fixed top
&.fixed-top {
& .toolbar {
@include box-shadow(0, 0, 4px, $g-gray);
}
.tab {
@include box-shadow(0, 1px, 4px, $g-gray);
}
}

// "Muted" elements
.muted {
color: $m-gray;
td {
color: $g-gray;
}
&:hover td {
color: $m-gray;
}
}

// The toolbar preferences
#toolbar-position,
#toolbar-theme, {
filter: brightness(0) invert(0.6);
}

// The toolbar menus
.ci-label {
&.active {
background-color: $t-dark;
}
&:hover {
background-color: $t-dark;
}
.badge {
background-color: $g-blue;
color: $m-gray;
}
}

// The tabs container
.tab {
background-color: $t-dark;
@include box-shadow(0, -1px, 4px, $g-gray);
}

// The "Timeline" tab
.timeline {
th,
td {
border-color: $g-gray;
}
.timer {
background-color: $g-orange;
}
}
}


// DEBUG VIEW
// ========================================================================== */

.debug-view.show-view {
border-color: $g-orange;
}
.debug-view-path {
background-color: $m-orange;
color: $g-gray;
}
149 changes: 149 additions & 0 deletions system/Debug/Toolbar/Views/SASS/_theme-light.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,149 @@
// IMPORTS
// ========================================================================== */

// The "box-shadow" mixin uses colors
@import '_mixins';

// Graphic charter
@import '_graphic-charter';


// DEBUG ICON
// ========================================================================== */

#debug-icon {
background-color: $t-light;
@include box-shadow(0, 0, 4px, $m-gray);
a:active, a:link, a:visited {
color: $g-orange;
}
}


// DEBUG BAR
// ========================================================================== */

#debug-bar {
background-color: $t-light;
color: $g-gray;

// Reset to prevent conflict with other CSS files */
h1,
h2,
h3,
p,
a,
button,
table,
thead,
tr,
td,
button,
.toolbar {
background-color: transparent;
color: $g-gray;
}

// Buttons
button {
background-color: $t-light;
}

// Tables
table {
strong {
color: $m-orange;
}
tbody tr {
&:hover {
background-color: $m-gray;
}
&.current {
background-color: $m-orange;
&:hover td {
background-color: $g-red;
color: $t-light;
}
}
}
}

// The toolbar
.toolbar {
background-color: $t-light;
@include box-shadow(0, 0, 4px, $m-gray);
img {
filter: brightness(0) invert(0.4);
}
}

// Fixed top
&.fixed-top {
& .toolbar {
@include box-shadow(0, 0, 4px, $m-gray);
}
.tab {
@include box-shadow(0, 1px, 4px, $m-gray);
}
}

// "Muted" elements
.muted {
color: $g-gray;
td {
color: $m-gray;
}
&:hover td {
color: $g-gray;
}
}

// The toolbar preferences
#toolbar-position,
#toolbar-theme, {
filter: brightness(0) invert(0.6);
}

// The toolbar menus
.ci-label {
&.active {
background-color: $m-gray;
}
&:hover {
background-color: $m-gray;
}
.badge {
background-color: $g-blue;
color: $t-light;
}
}

// The tabs container
.tab {
background-color: $t-light;
@include box-shadow(0, -1px, 4px, $m-gray);
}

// The "Timeline" tab
.timeline {
th,
td {
border-color: $m-gray;
}
.timer {
background-color: $g-orange;
}
}
}


// DEBUG VIEW
// ========================================================================== */

.debug-view.show-view {
border-color: $g-orange;
}
.debug-view-path {
background-color: $m-orange;
color: $g-gray;
}
Loading