Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] Error correction in reference to Query Builder emptyTable m… #2452

Merged
merged 2 commits into from
Dec 27, 2019

Conversation

jlamim
Copy link
Contributor

@jlamim jlamim commented Dec 12, 2019

Description
Fixed an error referencing the emptyTable method in the Query Builder documentation, where the method name was empty_table, when the correct one in the new version is emptyTable.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner
Copy link
Member

MGatner commented Dec 15, 2019

@jlamim This looks good but you need to sign your commits! I cannot merge a PR while it has unverified commits.

@jlamim
Copy link
Contributor Author

jlamim commented Dec 16, 2019

@MGatner, I added a new commit with a documentation update in the migrations part where in the reference table at the end of the documentation it referred to the storage path configuration, but it is not in the "/app/Config/Migrations.php" configuration file and this information could be confusing to readers.

@lonnieezell lonnieezell merged commit 0d75ea2 into codeigniter4:develop Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants