Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure previous_url() gets accurate URI. #2408

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Ensure previous_url() gets accurate URI. #2408

merged 1 commit into from
Nov 15, 2019

Conversation

lonnieezell
Copy link
Member

When storing previous url we should use current_url() to ensure we ge…t baseURL paths and any query vars.

Fixes #2378

MGatner
MGatner approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you've been doing a lot with the URL functions! This looks good to me, without digging.

@lonnieezell
Copy link
Member Author

Thanks! Was letting tests run last night as I crashed. So I'm glad you commented to remind me :)

@lonnieezell lonnieezell merged commit 4b9d151 into develop Nov 15, 2019
@lonnieezell lonnieezell deleted the previousurlfix branch June 24, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

previous_url() not loading the base path together
2 participants
@lonnieezell @MGatner