Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confer silent status to nested seeders #2389

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Nov 6, 2019

Description
Seeds can call other seeds (https://codeigniter4.github.io/userguide/dbmgmt/seeds.html#nesting-seeders) but since seeds are extensions of the seeder themselves the new seeds will start with their own silent value. This means any tests using nesting seeders will start displaying seed results for every test call, very undesirable.

This PR has the parent seeder pass its silent value to the child before running it.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell
Copy link
Member

Good catch. I approve.

@MGatner MGatner merged commit 2fa10ce into codeigniter4:develop Nov 6, 2019
@MGatner MGatner deleted the seeder-silence branch November 6, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants