Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace null log file extension check #2379

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Oct 31, 2019

Description
The recent Logger change to default to .log added a null check for config->fileExtension, but since this is defined in app/Config/Logger.php it won't normally be null, just empty.

This PR checks for an empty value (could also use ?: but this covers cases where it isn't set at all).

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner MGatner requested a review from jim-parry October 31, 2019 14:36
@lonnieezell lonnieezell merged commit 40367d9 into codeigniter4:develop Oct 31, 2019
@MGatner MGatner deleted the log-ext branch October 31, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants