Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Logger config #2358

Merged
merged 5 commits into from
Oct 22, 2019
Merged

Fix Logger config #2358

merged 5 commits into from
Oct 22, 2019

Conversation

jim-parry
Copy link
Contributor

Correct the Config/Logger

@MGatner
Copy link
Member

MGatner commented Oct 22, 2019

@jim-parry
Copy link
Contributor Author

I left tht because the docs say the default extension is "php".
All the "php" extension does is inject a DEFINED||exit scriptlet at the beginning of the log file.
This at least protects the developer who foolishy sticks their log folder somewhere accessible.

Alternate: make "log" the default logfile extension, and change the description in Config/Logger to explain the effect of "php"

@lonnieezell
Copy link
Member

I'm good with making the default extension .log, honestly.

@MGatner
Copy link
Member

MGatner commented Oct 22, 2019

I think it should be consistent with the Config file, for testing and for odd times when it comes up in testing, etc.

@jim-parry
Copy link
Contributor Author

Should be consistent now

@jim-parry
Copy link
Contributor Author

ohoh - I broke something. WIll return to this later this morning

@jim-parry jim-parry merged commit ba60732 into codeigniter4:develop Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Logger Path Duplicated
3 participants