Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in comments of Services.php #2356

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Fix typo in comments of Services.php #2356

merged 1 commit into from
Oct 21, 2019

Conversation

mladoux
Copy link
Contributor

@mladoux mladoux commented Oct 21, 2019

Corrected 'igration runner' to read 'Migration runner'.

Typographical error in comments only, no functional code changes.

Each pull request should address a single issue and have a meaningful title.

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

---------Remove from here down in your description----------

Notes

  • Pull requests must be in English
  • If the PR solves an issue, reference it with a suitable verb and the issue number
    (e.g. fixes 12345)
  • Unsolicited pull requests will be considered, but there is no guarantee of acceptance
  • Pull requests should be from a feature branch in the contributor's fork of the repository
    to the develop branch of the project repository

Corrected 'igration runner' to read 'Migration runner'.

Typographical error in comments only, no functional code changes.
@MGatner
Copy link
Member

MGatner commented Oct 21, 2019

Thanks @mladoux! For future reference, if you're just changing comments or the User Guide (i.e. nothing that needs testing) you can prefix your commit(s) with [ci skip] and it won't kick off the pipeline. Saves a few resources :)

@MGatner MGatner merged commit a1904bf into codeigniter4:develop Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants