Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer Toolbar Debug Toggle #2324

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Oct 11, 2019

Description
View/View uses CIDEBUG directly to determine whether to inject toolbar collector data, despite already having $this->debug which defaults to CIDEBUG. Using the constant directly makes it near impossible to exclude collector injections during testing.

This PR has render() check $this->debug instead, which should have the same behavior in all current cases but will allow direct overriding of the injection for test cases.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit 34a187c into codeigniter4:develop Oct 11, 2019
@MGatner MGatner deleted the view-debug branch October 11, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants