Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getErrors() for validation with redirect #2284

Merged
merged 2 commits into from
Oct 2, 2019

Conversation

michalsn
Copy link
Member

Description
When performing redirect _ci validation_errors session variable is not passed correctly.
Sadly this one is hard to test since we check ! is_cli() a couple of lines before.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner
Copy link
Member

MGatner commented Sep 28, 2019

I’ve actually been wondering if is_cli() should exempt testing. I’ve been doing that myself quite a bit.

@michalsn
Copy link
Member Author

There is a risk that this may affect tests - but I don't know how much (if any).

@MGatner
Copy link
Member

MGatner commented Oct 2, 2019

Seeing as how this is pretty much a typo I'm going with the change. Tests are good at the moment and if we need to adjust it is likely something that was wrong anyways.

@MGatner MGatner merged commit 1c42062 into codeigniter4:develop Oct 2, 2019
@michalsn michalsn deleted the fix_get_errors_bug branch March 5, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants