-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests setUp and tearDown: void #2267
Conversation
hmm - a couple of files changed here :-/ |
Good old recursive |
I'm baffled what happened to the test view files. I didn't touch them - maybe some style enforcement injected the newline? It's causing the tests to fail. I'm trying a manual update via GitHub UI but failing that the test might need to be updated. |
I find that the commit pre-hook can mangle the formatting. Maybe it needs to be made smarter or more context-sensitive. |
Yeah it's definitely breaking this - I think I will update the test for now because there is no way to commit those files without the newline. |
I have seen this before ... running a group of tests will have \n added to output, whereas running the entire suite doesn't, or vice-versa (can't remember which way it goes). |
Not sure but I might redo this and exclude those files from the original commit to prevent them changing. |
It looks like that fixed it. @jim-parry Do you feel okay about the tests embracing the newlines? |
I am ok with that - it is a different issue to track down at some point. |
Description
setUp()
andtearDown()
already always return void, but as of PHPUnit 8 the interface requires this in the declaration. This updates the test cases and all tests to add the explicit reference.Checklist: